detector_residuals: resolve per-frame XFELBeam for composite stills#1164
Draft
dwmoreau wants to merge 2 commits into
Draft
detector_residuals: resolve per-frame XFELBeam for composite stills#1164dwmoreau wants to merge 2 commits into
dwmoreau wants to merge 2 commits into
Conversation
cctbx.xfel.detector_residuals crashed with "XFELBeam has no fixed s0" on composite stills .expt output from the stills_process_imagesequence branch: each Experiment.beam is the shared wavelength-less XFELBeam, and the residual/prediction code calls beam.get_s0() / get_wavelength() both via StillsReflectionPredictor and in several direct sites. Resolve each experiment's per-frame monochromatic beam once, right after the experiments are loaded, via the new Experiment.get_monochromatic_beam() (XFELBeam + scan "wavelength" property -> monochromatic Beam). A no-op for ordinary beams. This tool only reads experiments, so replacing the beam in place is safe. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
dxtbx now makes XFELBeam/PolychromaticBeam direct siblings of Beam under BeamBase rather than subclasses, so isinstance(beam, Beam) is no longer True for them. Broaden mod_view's Format.setup() beam assert to BeamBase to match the new hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype branch, not intended for merge. It serves as a discussion point for what is necessary to convert dials.stills_process from ImageSet to ImageSequence. See the DIALS PR for more information: https://github.com/dials/dials/pull/3181